Skip to content

Fix method name in client cancellation send#76

Merged
jspahrsummers merged 1 commit into
modelcontextprotocol:mainfrom
efritz:patch-1
Dec 2, 2024
Merged

Fix method name in client cancellation send#76
jspahrsummers merged 1 commit into
modelcontextprotocol:mainfrom
efritz:patch-1

Conversation

@efritz

@efritz efritz commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

The server registers a notification handler on CancelledNotificationSchema, but is never called on client cancellation because of a mismatch in the method name. This fixes that mismatch.

Motivation and Context

Cancellation between server <-> client implementations does not seem to function correctly. There's no propagation of an abort signal from the client to the server.

How Has This Been Tested?

I made this change in the dependency tree of a local application and saw that the server signal is properly canceled after the change.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

The server registers a notification handler on `CancelledNotificationSchema`, but is never called on client cancellation because of a mismatch in the method name. This fixes that mismatch.
@jspahrsummers

Copy link
Copy Markdown
Member

Very good catch, thank you!

@jspahrsummers jspahrsummers merged commit becd787 into modelcontextprotocol:main Dec 2, 2024
@efritz efritz deleted the patch-1 branch December 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants